Ajout d'une catégorie jeux dans le tryouts, chacun des jeux offre des rôles différents pour les membres d'équipes. Remodelage du code un peu et ajout de docu

routes/tryouts.py

@@ -1,17 +1,40 @@
+"""Tryout management routes for creating, viewing, and managing tryout events.
+
+This module handles CRUD operations for tryouts and player registrations.
+"""
+
 from flask import Blueprint, render_template, redirect, url_for, flash, request
 from flask_login import login_required, current_user
 from extensions import db
-from models import User, Tryout, TryoutRegistration, Evaluation, Team, TeamMember, OrgTeam, Match, MatchParticipant
+from models import User, Tryout, TryoutRegistration, Evaluation, Team, TeamMember, OrgTeam, Match, MatchParticipant, ESPORT_GAMES, GAME_POSITIONS
 from datetime import datetime
 
 tryouts_bp = Blueprint('tryouts', __name__, url_prefix='/tryouts')
 
+
 def can_manage():
+    """Check if current user can manage tryouts.
+    
+    Returns:
+        bool: True if user is president or manager.
+    """
     return current_user.role in ['president', 'manager']
 
+
 @tryouts_bp.route('')
 @login_required
 def list_tryouts():
+    """List all tryouts visible to the current user.
+    
+    Shows tryouts filtered by user's role:
+        - President: All tryouts
+        - Manager: Only their created tryouts
+        - Coach: Tryouts targeting their org team
+        - Player: Upcoming and in-progress tryouts
+    
+    Returns:
+        Response: Rendered tryouts list template.
+    """
     if current_user.role == 'president':
         tryouts = Tryout.query.order_by(Tryout.date.desc()).all()
     elif current_user.role == 'manager':
@@ -29,9 +52,20 @@ def list_tryouts():
         tryouts = Tryout.query.order_by(Tryout.date.desc()).all()
     return render_template('pages/tryouts.html', tryouts=tryouts, now=datetime.utcnow())
 
+
 @tryouts_bp.route('/create', methods=['GET', 'POST'])
 @login_required
 def create_tryout():
+    """Create a new tryout event.
+    
+    GET: Render the tryout creation form.
+    POST: Create a tryout with the submitted details.
+    
+    Requires president or manager role.
+    
+    Returns:
+        Response: Create form or redirect to the new tryout.
+    """
     if not can_manage():
         flash('You do not have permission to create tryouts.', 'danger')
         return redirect(url_for('tryouts.list_tryouts'))
@@ -41,6 +75,7 @@ def create_tryout():
     if request.method == 'POST':
         title = request.form.get('title')
         description = request.form.get('description')
+        game = request.form.get('game')
         date_str = request.form.get('date')
         location = request.form.get('location')
         max_players = request.form.get('max_players')
@@ -55,6 +90,7 @@ def create_tryout():
         tryout = Tryout(
             title=title,
             description=description,
+            game=game,
             date=date_obj,
             location=location,
             max_players=int(max_players) if max_players else None,
@@ -67,11 +103,25 @@ def create_tryout():
         flash('Tryout created successfully!', 'success')
         return redirect(url_for('tryouts.view_tryout', tryout_id=tryout.id))
 
-    return render_template('pages/create_tryout.html', org_teams=org_teams)
+    return render_template('pages/create_tryout.html', org_teams=org_teams, esport_games=ESPORT_GAMES)
+
 
 @tryouts_bp.route('/<int:tryout_id>/edit', methods=['GET', 'POST'])
 @login_required
 def edit_tryout(tryout_id):
+    """Edit an existing tryout event.
+    
+    GET: Render the tryout edit form with current data.
+    POST: Update the tryout with submitted changes.
+    
+    Permission based on can_manage_this_tryout check.
+    
+    Args:
+        tryout_id: The ID of the tryout to edit.
+        
+    Returns:
+        Response: Edit form or redirect to tryout view.
+    """
     tryout = Tryout.query.get_or_404(tryout_id)
 
     # Permission: president, manager (own tryouts), or coach (targets their team)
@@ -84,6 +134,7 @@ def edit_tryout(tryout_id):
     if request.method == 'POST':
         title = request.form.get('title')
         description = request.form.get('description')
+        game = request.form.get('game')
         date_str = request.form.get('date')
         location = request.form.get('location')
         max_players = request.form.get('max_players')
@@ -93,10 +144,11 @@ def edit_tryout(tryout_id):
             date_obj = datetime.strptime(date_str, '%Y-%m-%d').date()
         except (ValueError, TypeError):
             flash('Invalid date format.', 'danger')
-            return render_template('pages/edit_tryout.html', tryout=tryout, org_teams=org_teams)
+            return render_template('pages/edit_tryout.html', tryout=tryout, org_teams=org_teams, esport_games=ESPORT_GAMES)
 
         tryout.title = title
         tryout.description = description
+        tryout.game = game
         tryout.date = date_obj
         tryout.location = location
         tryout.max_players = int(max_players) if max_players else None
@@ -105,11 +157,23 @@ def edit_tryout(tryout_id):
         flash('Tryout updated successfully!', 'success')
         return redirect(url_for('tryouts.view_tryout', tryout_id=tryout.id))
 
-    return render_template('pages/edit_tryout.html', tryout=tryout, org_teams=org_teams)
+    return render_template('pages/edit_tryout.html', tryout=tryout, org_teams=org_teams, esport_games=ESPORT_GAMES)
+
 
 @tryouts_bp.route('/<int:tryout_id>')
 @login_required
 def view_tryout(tryout_id):
+    """View a specific tryout with all details.
+    
+    Displays tryout information, registered players, evaluations, teams,
+    matches, and evaluation status information.
+    
+    Args:
+        tryout_id: The ID of the tryout to view.
+        
+    Returns:
+        Response: Rendered tryout detail template.
+    """
     tryout = Tryout.query.get_or_404(tryout_id)
     registrations = TryoutRegistration.query.filter_by(tryout_id=tryout_id).all()
     registered_players = [User.query.get(r.player_id) for r in registrations if r.player_id]
@@ -156,7 +220,7 @@ def view_tryout(tryout_id):
         ).first() is not None
         
         can_view_calendar = is_registered or player_in_match
-    
+
     # Get all players (for manager registration dropdown)
     all_players = User.query.filter_by(role='player').order_by(User.full_name).all()
     
@@ -200,11 +264,24 @@ def view_tryout(tryout_id):
                          all_players=all_players,
                          matches=matches,
                          match_data=match_data,
+                         game_positions=GAME_POSITIONS,
                          now=datetime.utcnow())
 
+
 @tryouts_bp.route('/<int:tryout_id>/register', methods=['POST'])
 @login_required
 def register_for_tryout(tryout_id):
+    """Register a player for a tryout.
+    
+    Allows players to register for tryouts. Validates that the tryout
+    is accepting registrations and not at capacity.
+    
+    Args:
+        tryout_id: The ID of the tryout to register for.
+        
+    Returns:
+        Response: Redirect to tryout view with status message.
+    """
     tryout = Tryout.query.get_or_404(tryout_id)
     if current_user.role != 'player':
         flash('Only players can register for tryouts.', 'danger')
@@ -231,9 +308,20 @@ def register_for_tryout(tryout_id):
     flash('Successfully registered for tryout!', 'success')
     return redirect(url_for('tryouts.view_tryout', tryout_id=tryout_id))
 
+
 @tryouts_bp.route('/<int:tryout_id>/status', methods=['POST'])
 @login_required
 def update_status(tryout_id):
+    """Update the status of a tryout.
+    
+    Changes tryout status between upcoming, in_progress, and completed.
+    
+    Args:
+        tryout_id: The ID of the tryout to update.
+        
+    Returns:
+        Response: Redirect to tryout view.
+    """
     tryout = Tryout.query.get_or_404(tryout_id)
     if not current_user.can_manage_this_tryout(tryout):
         flash('Permission denied.', 'danger')
@@ -245,9 +333,19 @@ def update_status(tryout_id):
         flash(f'Tryout status updated to {new_status}.', 'success')
     return redirect(url_for('tryouts.view_tryout', tryout_id=tryout_id))
 
+
 @tryouts_bp.route('/<int:tryout_id>/registration/<int:player_id>/status', methods=['POST'])
 @login_required
 def update_registration_status(tryout_id, player_id):
+    """Update the attendance status of a tryout registration.
+    
+    Args:
+        tryout_id: The ID of the tryout.
+        player_id: The ID of the player whose status to update.
+        
+    Returns:
+        Response: Redirect to tryout view.
+    """
     tryout = Tryout.query.get_or_404(tryout_id)
     if not current_user.can_manage_this_tryout(tryout):
         flash('Permission denied.', 'danger')
@@ -261,9 +359,20 @@ def update_registration_status(tryout_id, player_id):
         flash('Registration status updated.', 'success')
     return redirect(url_for('tryouts.view_tryout', tryout_id=tryout_id))
 
+
 @tryouts_bp.route('/<int:tryout_id>/register_player', methods=['POST'])
 @login_required
 def register_player(tryout_id):
+    """Manually register a player for a tryout (by managers/coaches).
+    
+    Allows authorized users to register players on their behalf.
+    
+    Args:
+        tryout_id: The ID of the tryout.
+        
+    Returns:
+        Response: Redirect to tryout view with status message.
+    """
     tryout = Tryout.query.get_or_404(tryout_id)
     if not current_user.can_manage_this_tryout(tryout):
         flash('Permission denied.', 'danger')
@@ -296,9 +405,18 @@ def register_player(tryout_id):
     flash(f'{player.full_name} registered for tryout!', 'success')
     return redirect(url_for('tryouts.view_tryout', tryout_id=tryout_id))
 
+
 @tryouts_bp.route('/<int:tryout_id>/team/create', methods=['POST'])
 @login_required
 def create_team(tryout_id):
+    """Create a tryout-specific team.
+    
+    Args:
+        tryout_id: The ID of the tryout to create the team for.
+        
+    Returns:
+        Response: Redirect to tryout view with status message.
+    """
     tryout = Tryout.query.get_or_404(tryout_id)
     if not current_user.can_manage_this_tryout(tryout):
         flash('Permission denied.', 'danger')
@@ -312,9 +430,19 @@ def create_team(tryout_id):
         flash(f'Team "{team_name}" created!', 'success')
     return redirect(url_for('tryouts.view_tryout', tryout_id=tryout_id))
 
+
 @tryouts_bp.route('/<int:tryout_id>/team/<int:team_id>/add', methods=['POST'])
 @login_required
 def add_to_team(tryout_id, team_id):
+    """Add a player to a tryout team.
+    
+    Args:
+        tryout_id: The ID of the tryout.
+        team_id: The ID of the team to add the player to.
+        
+    Returns:
+        Response: Redirect to tryout view with status message.
+    """
     team = Team.query.get_or_404(team_id)
     tryout = Tryout.query.get_or_404(tryout_id)
     if not current_user.can_manage_this_tryout(tryout):