diff --git a/app/static/css/style.css b/app/static/css/style.css index 1660733..04e172e 100644 --- a/app/static/css/style.css +++ b/app/static/css/style.css @@ -2122,3 +2122,73 @@ a:hover { color: var(--primary-dark); } grid-template-columns: 1fr; } } + +/* Evaluation comments - separate grid so long notes stay readable */ +.eval-comments { + display: grid; + grid-template-columns: repeat(auto-fit, minmax(260px, 1fr)); + gap: 12px; + margin-top: 16px; +} + +.eval-comments-title { + grid-column: 1 / -1; + margin: 0 0 4px; + font-size: 0.95rem; + font-weight: 600; +} + +.eval-comment { + background: var(--gray-50); + border: 1px solid var(--gray-200); + border-radius: var(--radius-sm); + padding: 12px 14px; +} + +.eval-comment-text { + margin: 0 0 10px; + white-space: pre-wrap; + word-break: break-word; + color: var(--gray-800); +} + +.eval-comment-meta { + display: flex; + justify-content: space-between; + gap: 8px; + flex-wrap: wrap; + font-size: 0.85rem; + color: var(--gray-500); +} + +.eval-comment-author strong { + color: var(--gray-700); + font-weight: 600; +} + +[data-theme="dark"] .eval-comment { + background: var(--bg-tertiary); + border-color: var(--border-color); +} + +[data-theme="dark"] .eval-comment-text { + color: var(--text-primary); +} + +[data-theme="dark"] .eval-comment-meta { + color: var(--text-muted); +} + +[data-theme="dark"] .eval-comment-author strong { + color: var(--text-secondary); +} + +.eval-comments-empty { + margin: 8px 0 0; + color: var(--gray-500); + font-size: 0.9rem; +} + +[data-theme="dark"] .eval-comments-empty { + color: var(--text-muted); +} diff --git a/app/templates/pages/evaluations.html b/app/templates/pages/evaluations.html index ac4812f..d01cceb 100644 --- a/app/templates/pages/evaluations.html +++ b/app/templates/pages/evaluations.html @@ -79,7 +79,6 @@ {% endfor %} {{ _('Overall') }} {{ _('Position') }} - {{ _('Comment') }} {{ _('Date') }} @@ -93,16 +92,35 @@ {% endfor %} {{ ev.overall if ev.overall is not none else '-' }} {{ ev.position or '-' }} - {{ ev.comment or '-' }} {{ ev.date.strftime('%m/%d/%Y') if ev.date else '-' }} {% else %} - {{ _('No evaluations for this player.') }} + {{ _('No evaluations for this player.') }} {% endfor %} + + {% if entry.evaluations %} + {% set comment_evals = entry.evaluations | selectattr('comment') | list %} +
+

{{ _('Comments') }}

+ {% if comment_evals %} + {% for ev in comment_evals %} +
+

{{ ev.comment }}

+
+ {{ _('Evaluator') }} : {{ ev.evaluator.username if ev.evaluator else _('Deleted evaluator') }} + {{ ev.tryout.title if ev.tryout else _('Deleted tryout') }} · {{ ev.date.strftime('%m/%d/%Y') if ev.date else '-' }} +
+
+ {% endfor %} + {% else %} +

{{ _('No comments') }}

+ {% endif %} +
+ {% endif %} @@ -131,7 +149,6 @@ .eval-chevron { transition: transform 0.15s ease; font-size: 0.75rem; } .eval-detail-inner { padding: 8px 4px; } .eval-detail-inner .table { margin-bottom: 0; } -.eval-comment { max-width: 320px; white-space: pre-wrap; } .player-nav { display: flex; gap: 8px; align-items: center; } .is-disabled { opacity: 0.5; pointer-events: none; } diff --git a/app/templates/pages/player_evaluations.html b/app/templates/pages/player_evaluations.html index 8a05f81..602364d 100644 --- a/app/templates/pages/player_evaluations.html +++ b/app/templates/pages/player_evaluations.html @@ -64,7 +64,6 @@ {% endfor %} {{ _('Overall') }} {{ _('Position') }} - {{ _('Comment') }} {{ _('Date') }} @@ -78,12 +77,11 @@ {% endfor %} {{ ev.overall if ev.overall is not none else '-' }} {{ ev.position or '-' }} - {{ ev.comment or '-' }} {{ ev.date.strftime('%m/%d/%Y') if ev.date else '-' }} {% else %} - +

{{ _('No evaluations for this player yet') }}

@@ -94,6 +92,35 @@
+ + {% if evaluations %} + {% set comment_evals = evaluations | selectattr('comment') | list %} +
+
+

{{ _('Comments') }}

+
+
+ {% if comment_evals %} +
+ {% for ev in comment_evals %} +
+

{{ ev.comment }}

+
+ {{ _('Evaluator') }} : {{ ev.evaluator.username if ev.evaluator else _('Deleted evaluator') }} + {{ ev.tryout.title if ev.tryout else _('Deleted tryout') }} · {{ ev.date.strftime('%m/%d/%Y') if ev.date else '-' }} +
+
+ {% endfor %} +
+ {% else %} +
+ +

{{ _('No comments') }}

+
+ {% endif %} +
+
+ {% endif %} {% endblock %} @@ -103,6 +130,5 @@ .view-toggle { display: flex; gap: 8px; } .player-nav { display: flex; gap: 8px; align-items: center; } .is-disabled { opacity: 0.5; pointer-events: none; } -.eval-comment { max-width: 320px; white-space: pre-wrap; } {% endblock %} \ No newline at end of file diff --git a/app/translations/en/LC_MESSAGES/messages.mo b/app/translations/en/LC_MESSAGES/messages.mo index 080beb9..b9c72fe 100644 Binary files a/app/translations/en/LC_MESSAGES/messages.mo and b/app/translations/en/LC_MESSAGES/messages.mo differ diff --git a/app/translations/en/LC_MESSAGES/messages.po b/app/translations/en/LC_MESSAGES/messages.po index 7e1f100..4ee68ac 100644 --- a/app/translations/en/LC_MESSAGES/messages.po +++ b/app/translations/en/LC_MESSAGES/messages.po @@ -1826,9 +1826,16 @@ msgid "Enter position (optional)" msgstr "Enter position (optional)" #: app/templates/pages/evaluate_player.html:121 +#: app/templates/pages/player_evaluations.html +#: app/templates/pages/evaluations.html msgid "Comments" msgstr "Comments" +#: app/templates/pages/player_evaluations.html +#: app/templates/pages/evaluations.html +msgid "No comments" +msgstr "No comments" + #: app/templates/pages/evaluate_player.html:122 msgid "Enter your evaluation notes..." msgstr "Enter your evaluation notes..." diff --git a/app/translations/fr/LC_MESSAGES/messages.mo b/app/translations/fr/LC_MESSAGES/messages.mo index 5e241b7..1ff1e2e 100644 Binary files a/app/translations/fr/LC_MESSAGES/messages.mo and b/app/translations/fr/LC_MESSAGES/messages.mo differ diff --git a/app/translations/fr/LC_MESSAGES/messages.po b/app/translations/fr/LC_MESSAGES/messages.po index 27f061b..a41082b 100644 --- a/app/translations/fr/LC_MESSAGES/messages.po +++ b/app/translations/fr/LC_MESSAGES/messages.po @@ -1836,9 +1836,16 @@ msgid "Enter position (optional)" msgstr "Saisir un poste (facultatif)" #: app/templates/pages/evaluate_player.html:121 +#: app/templates/pages/player_evaluations.html +#: app/templates/pages/evaluations.html msgid "Comments" msgstr "Commentaires" +#: app/templates/pages/player_evaluations.html +#: app/templates/pages/evaluations.html +msgid "No comments" +msgstr "Aucun commentaire" + #: app/templates/pages/evaluate_player.html:122 msgid "Enter your evaluation notes..." msgstr "Vos notes d’évaluation..."