fix probleme de match dans les calendriers et ajout de boutton delete pour les matchs
CI - Security, Lint & Tests / validate (push) Failing after 1m0s
CI - Security, Lint & Tests / validate (push) Failing after 1m0s
This commit is contained in:
+125
-61
@@ -26,11 +26,13 @@ from app.models import (
|
||||
PlayerDisponibility,
|
||||
Scout,
|
||||
Team,
|
||||
TeamMatch,
|
||||
TeamMember,
|
||||
Tryout,
|
||||
TryoutRegistration,
|
||||
User,
|
||||
)
|
||||
from app.permissions import visible_org_teams
|
||||
from app.services.scheduling import notify_participants, zip_participants
|
||||
from app.validators import MatchEditSchema, MatchSchema
|
||||
|
||||
@@ -74,6 +76,25 @@ def default_end_time(date, start_time):
|
||||
return (datetime.combine(date, start_time) + timedelta(minutes=DEFAULT_MATCH_MINUTES)).time()
|
||||
|
||||
|
||||
def calendar_event_time_fields(date, start_time, end_time):
|
||||
"""FullCalendar date/time fields for a match.
|
||||
|
||||
A date-only event renders in the all-day row; a ``start``/``end`` with a
|
||||
time places it on the clock for the same calendar day. Matches, team
|
||||
matches and one-on-one sessions are stored as a date plus optional time
|
||||
columns, so the feed translates that into the shape FullCalendar expects.
|
||||
"""
|
||||
if not start_time:
|
||||
return {'date': date.strftime('%Y-%m-%d'), 'allDay': True}
|
||||
fields = {
|
||||
'start': f'{date.isoformat()}T{start_time.strftime("%H:%M:%S")}',
|
||||
'allDay': False,
|
||||
}
|
||||
if end_time:
|
||||
fields['end'] = f'{date.isoformat()}T{end_time.strftime("%H:%M:%S")}'
|
||||
return fields
|
||||
|
||||
|
||||
def create_participants(match, data):
|
||||
"""Attach participants to a match, per its type.
|
||||
|
||||
@@ -165,13 +186,17 @@ def api_events():
|
||||
president — and then issue one MatchParticipant query per match to find
|
||||
out whether the viewer was in it. The calendar's cost grew with the
|
||||
whole history, on every navigation.
|
||||
|
||||
Tryout matches, regular-season team matches and approved one-on-one
|
||||
sessions share this feed. Timed rows carry `start`/`end` so
|
||||
FullCalendar places them on the clock instead of the all-day row.
|
||||
"""
|
||||
events = []
|
||||
tryouts = get_visible_tryouts_for_user()
|
||||
window_start, window_end = calendar_window(request.args)
|
||||
tryouts_by_id = {tryout.id: tryout for tryout in tryouts}
|
||||
|
||||
if tryouts_by_id:
|
||||
window_start, window_end = calendar_window(request.args)
|
||||
query = Match.query.filter(Match.tryout_id.in_(tryouts_by_id))
|
||||
if window_start:
|
||||
query = query.filter(Match.date >= window_start)
|
||||
@@ -225,30 +250,71 @@ def api_events():
|
||||
|
||||
user_participant = mine_by_match.get(match.id)
|
||||
|
||||
events.append(
|
||||
{
|
||||
'id': f'match_{match.id}',
|
||||
'title': match.title,
|
||||
'date': match.date.strftime('%Y-%m-%d'),
|
||||
'type': 'match',
|
||||
'color': match_color,
|
||||
'extendedProps': {
|
||||
'location': match.location or tryout.location or 'TBD',
|
||||
'status': match.status,
|
||||
'description': match.description or '',
|
||||
'match_type': match.match_type,
|
||||
'tryout_id': tryout.id,
|
||||
'match_id': match.id,
|
||||
'start_time': start_time_str,
|
||||
'end_time': end_time_str,
|
||||
'participants': participants_str,
|
||||
'user_participant_id': user_participant.id if user_participant else None,
|
||||
'user_attendance_confirmed': user_participant.attendance_confirmed
|
||||
if user_participant
|
||||
else False,
|
||||
},
|
||||
}
|
||||
)
|
||||
event = {
|
||||
'id': f'match_{match.id}',
|
||||
'title': match.title,
|
||||
'type': 'match',
|
||||
'color': match_color,
|
||||
'extendedProps': {
|
||||
'location': match.location or tryout.location or 'TBD',
|
||||
'status': match.status,
|
||||
'description': match.description or '',
|
||||
'match_type': match.match_type,
|
||||
'tryout_id': tryout.id,
|
||||
'match_id': match.id,
|
||||
'start_time': start_time_str,
|
||||
'end_time': end_time_str,
|
||||
'participants': participants_str,
|
||||
'user_participant_id': user_participant.id if user_participant else None,
|
||||
'user_attendance_confirmed': user_participant.attendance_confirmed
|
||||
if user_participant
|
||||
else False,
|
||||
},
|
||||
}
|
||||
event.update(calendar_event_time_fields(match.date, match.start_time, match.end_time))
|
||||
events.append(event)
|
||||
|
||||
# Regular-season team matches: a separate table from tryout matches, but
|
||||
# the same calendar. Visible to the roles that can see the org team.
|
||||
if isinstance(current_user, (Admin, Manager)):
|
||||
team_query = TeamMatch.query
|
||||
elif isinstance(current_user, (Coach, Player)):
|
||||
team_ids = [team.id for team in visible_org_teams(current_user)]
|
||||
team_query = (
|
||||
TeamMatch.query.filter(TeamMatch.org_team_id.in_(team_ids))
|
||||
if team_ids
|
||||
else TeamMatch.query.filter(TeamMatch.id == -1)
|
||||
)
|
||||
else:
|
||||
team_query = TeamMatch.query.filter(TeamMatch.id == -1)
|
||||
|
||||
if window_start:
|
||||
team_query = team_query.filter(TeamMatch.date >= window_start)
|
||||
if window_end:
|
||||
team_query = team_query.filter(TeamMatch.date <= window_end)
|
||||
|
||||
for team_match in team_query.options(joinedload(TeamMatch.org_team)).all():
|
||||
start_time_str = team_match.start_time.strftime('%H:%M') if team_match.start_time else None
|
||||
end_time_str = team_match.end_time.strftime('%H:%M') if team_match.end_time else None
|
||||
event = {
|
||||
'id': f'team_match_{team_match.id}',
|
||||
'title': team_match.title,
|
||||
'type': 'team_match',
|
||||
'color': '#3b82f6',
|
||||
'extendedProps': {
|
||||
'location': team_match.location or 'TBD',
|
||||
'status': team_match.status,
|
||||
'description': team_match.description or '',
|
||||
'org_team': team_match.org_team.name if team_match.org_team else '',
|
||||
'opponent': team_match.opponent or '',
|
||||
'start_time': start_time_str,
|
||||
'end_time': end_time_str,
|
||||
},
|
||||
}
|
||||
event.update(
|
||||
calendar_event_time_fields(team_match.date, team_match.start_time, team_match.end_time)
|
||||
)
|
||||
events.append(event)
|
||||
|
||||
# Add approved One on One sessions for the current user (player or coach)
|
||||
if isinstance(current_user, Player):
|
||||
@@ -263,23 +329,22 @@ def api_events():
|
||||
one_on_ones = []
|
||||
|
||||
for ooo in one_on_ones:
|
||||
events.append(
|
||||
{
|
||||
'id': f'one_on_one_{ooo.id}',
|
||||
'title': f'1:1 - {ooo.player.full_name} & {ooo.coach.full_name}',
|
||||
'date': ooo.date.strftime('%Y-%m-%d'),
|
||||
'type': 'one_on_one',
|
||||
'color': '#8b5cf6',
|
||||
'extendedProps': {
|
||||
'location': 'Discord / Voice Chat',
|
||||
'status': 'approved',
|
||||
'description': ooo.points or 'One on One session',
|
||||
'start_time': ooo.start_time.strftime('%H:%M') if ooo.start_time else None,
|
||||
'end_time': ooo.end_time.strftime('%H:%M') if ooo.end_time else None,
|
||||
'participants': f"{ooo.player.full_name} with {ooo.coach.full_name}",
|
||||
},
|
||||
}
|
||||
)
|
||||
event = {
|
||||
'id': f'one_on_one_{ooo.id}',
|
||||
'title': f'1:1 - {ooo.player.full_name} & {ooo.coach.full_name}',
|
||||
'type': 'one_on_one',
|
||||
'color': '#8b5cf6',
|
||||
'extendedProps': {
|
||||
'location': 'Discord / Voice Chat',
|
||||
'status': 'approved',
|
||||
'description': ooo.points or 'One on One session',
|
||||
'start_time': ooo.start_time.strftime('%H:%M') if ooo.start_time else None,
|
||||
'end_time': ooo.end_time.strftime('%H:%M') if ooo.end_time else None,
|
||||
'participants': f"{ooo.player.full_name} with {ooo.coach.full_name}",
|
||||
},
|
||||
}
|
||||
event.update(calendar_event_time_fields(ooo.date, ooo.start_time, ooo.end_time))
|
||||
events.append(event)
|
||||
|
||||
return jsonify(events)
|
||||
|
||||
@@ -351,25 +416,24 @@ def api_events_for_tryout(tryout_id):
|
||||
start_time_str = match.start_time.strftime('%H:%M') if match.start_time else None
|
||||
end_time_str = match.end_time.strftime('%H:%M') if match.end_time else None
|
||||
|
||||
events.append(
|
||||
{
|
||||
'id': f'match_{match.id}',
|
||||
'title': match.title,
|
||||
'date': match.date.strftime('%Y-%m-%d'),
|
||||
'type': 'match',
|
||||
'color': match_color,
|
||||
'extendedProps': {
|
||||
'location': match.location or tryout.location or 'TBD',
|
||||
'status': match.status,
|
||||
'match_type': match.match_type,
|
||||
'tryout_id': tryout.id,
|
||||
'match_id': match.id,
|
||||
'participants': participants_str,
|
||||
'start_time': start_time_str,
|
||||
'end_time': end_time_str,
|
||||
},
|
||||
}
|
||||
)
|
||||
event = {
|
||||
'id': f'match_{match.id}',
|
||||
'title': match.title,
|
||||
'type': 'match',
|
||||
'color': match_color,
|
||||
'extendedProps': {
|
||||
'location': match.location or tryout.location or 'TBD',
|
||||
'status': match.status,
|
||||
'match_type': match.match_type,
|
||||
'tryout_id': tryout.id,
|
||||
'match_id': match.id,
|
||||
'participants': participants_str,
|
||||
'start_time': start_time_str,
|
||||
'end_time': end_time_str,
|
||||
},
|
||||
}
|
||||
event.update(calendar_event_time_fields(match.date, match.start_time, match.end_time))
|
||||
events.append(event)
|
||||
|
||||
return jsonify(events)
|
||||
|
||||
|
||||
@@ -346,6 +346,14 @@ function showEventModal(event) {
|
||||
grid.appendChild(detailItem('Teams', buildTeamsNode(props), true));
|
||||
}
|
||||
|
||||
// Team match details
|
||||
if (type === 'team_match') {
|
||||
grid.appendChild(detailItem('Team', document.createTextNode(props.org_team || 'Team')));
|
||||
if (props.opponent) {
|
||||
grid.appendChild(detailItem('Opponent', document.createTextNode(props.opponent)));
|
||||
}
|
||||
}
|
||||
|
||||
if (props.description) {
|
||||
grid.appendChild(detailItem('Description', multilineNode(props.description), true));
|
||||
}
|
||||
|
||||
@@ -458,6 +458,12 @@
|
||||
<a href="{{ url_for('matches.edit_match', match_id=m.id) }}" class="btn btn-sm btn-outline">
|
||||
<i class="fas fa-edit"></i> {{ _('Edit') }}
|
||||
</a>
|
||||
<form method="POST" action="{{ url_for('matches.delete_match', match_id=m.id) }}" class="inline-form" data-confirm="{{ _('Delete this match?') }}">
|
||||
<input type="hidden" name="csrf_token" value="{{ csrf_token() }}"/>
|
||||
<button type="submit" class="btn btn-sm btn-danger" title="{{ _('Delete Match') }}">
|
||||
<i class="fas fa-trash"></i> {{ _('Delete') }}
|
||||
</button>
|
||||
</form>
|
||||
{% endif %}
|
||||
<a href="{{ url_for('users.add_note_from_match', match_id=m.id) }}" class="btn btn-sm btn-primary" title="{{ _('Add Note for this Match') }}">
|
||||
<i class="fas fa-sticky-note"></i> {{ _('Note') }}
|
||||
|
||||
Reference in New Issue
Block a user