ajout de tests

app/routes/tryouts.py

@@ -139,12 +139,12 @@ def list_tryouts():
 @login_required
 def create_tryout():
     """Create a new tryout event. Requires Admin or Manager."""
-    if not can_manage():
-        flash(_('You do not have permission to create tryouts.'), 'danger')
+    if tryouts_locked():
+        flash('Tryouts are currently closed. An admin must open tryouts before changes can be made.', 'danger')
         return redirect(url_for('tryouts.list_tryouts'))
 
-    if tryouts_locked():
-        flash(_('Tryouts are currently closed. An admin must open tryouts before changes can be made.'), 'danger')
+    if not can_manage():
+        flash(_('You do not have permission to create tryouts.'), 'danger')
         return redirect(url_for('tryouts.list_tryouts'))
 
     org_teams = OrgTeam.query.order_by(OrgTeam.name).all()
@@ -203,14 +203,14 @@ def edit_tryout(tryout_id):
     """Edit an existing tryout event. Permission based on can_manage_this_tryout."""
     tryout = db.get_or_404(Tryout, tryout_id)
 
+    if tryouts_locked():
+        flash('Tryouts are currently closed. An admin must open tryouts before changes can be made.', 'danger')
+        return redirect(url_for('tryouts.view_tryout', tryout_id=tryout.id))
+
     if not current_user.can_manage_this_tryout(tryout):
         flash(_('You do not have permission to edit this tryout.'), 'danger')
         return redirect(url_for('tryouts.list_tryouts'))
 
-    if tryouts_locked():
-        flash(_('Tryouts are currently closed. An admin must open tryouts before changes can be made.'), 'danger')
-        return redirect(url_for('tryouts.view_tryout', tryout_id=tryout.id))
-
     if tryout.is_ended:
         flash(_('This tryout has ended and can no longer be modified.'), 'danger')
         return redirect(url_for('tryouts.view_tryout', tryout_id=tryout.id))
@@ -499,12 +499,13 @@ def register_for_tryout(tryout_id):
 def update_status(tryout_id):
     """Update the status of a tryout."""
     tryout = db.get_or_404(Tryout, tryout_id)
+    if tryouts_locked():
+        flash('Tryouts are currently closed. An admin must open tryouts before changes can be made.', 'danger')
+        return redirect(url_for('tryouts.view_tryout', tryout_id=tryout_id))
+
     if not current_user.can_manage_this_tryout(tryout):
         flash(_('Permission denied.'), 'danger')
         return redirect(url_for('tryouts.list_tryouts'))
-    if tryouts_locked():
-        flash(_('Tryouts are currently closed. An admin must open tryouts before changes can be made.'), 'danger')
-        return redirect(url_for('tryouts.view_tryout', tryout_id=tryout_id))
     try:
         data = TryoutStatusSchema().load(form_payload(list_fields=()))
     except ValidationError as err:
@@ -522,14 +523,14 @@ def update_status(tryout_id):
 def update_registration_status(tryout_id, player_id):
     """Update a registration's attendance status."""
     tryout = db.get_or_404(Tryout, tryout_id)
+    if tryouts_locked():
+        flash('Tryouts are currently closed. An admin must open tryouts before changes can be made.', 'danger')
+        return redirect(url_for('tryouts.view_tryout', tryout_id=tryout_id))
+
     if not current_user.can_manage_this_tryout(tryout):
         flash(_('Permission denied.'), 'danger')
         return redirect(url_for('tryouts.list_tryouts'))
 
-    if tryouts_locked():
-        flash(_('Tryouts are currently closed. An admin must open tryouts before changes can be made.'), 'danger')
-        return redirect(url_for('tryouts.view_tryout', tryout_id=tryout_id))
-
     registration = TryoutRegistration.query.filter_by(
         tryout_id=tryout_id, player_id=player_id
     ).first_or_404()
@@ -550,12 +551,13 @@ def update_registration_status(tryout_id, player_id):
 def register_player(tryout_id):
     """Manually register a player for a tryout (by managers/coaches)."""
     tryout = locked_tryout_or_404(tryout_id)
+    if tryouts_locked():
+        flash('Tryouts are currently closed. An admin must open tryouts before changes can be made.', 'danger')
+        return redirect(url_for('tryouts.view_tryout', tryout_id=tryout_id))
+
     if not current_user.can_manage_this_tryout(tryout):
         flash(_('Permission denied.'), 'danger')
         return redirect(url_for('tryouts.view_tryout', tryout_id=tryout_id))
-    if tryouts_locked():
-        flash(_('Tryouts are currently closed. An admin must open tryouts before changes can be made.'), 'danger')
-        return redirect(url_for('tryouts.view_tryout', tryout_id=tryout_id))
     try:
         data = PlayerSelectionSchema().load(form_payload())
     except ValidationError as err:
@@ -600,14 +602,14 @@ def register_player(tryout_id):
 def remove_player(tryout_id, player_id):
     """Remove a registered player from a tryout (cascades to teams/matches)."""
     tryout = db.get_or_404(Tryout, tryout_id)
+    if tryouts_locked():
+        flash('Tryouts are currently closed. An admin must open tryouts before changes can be made.', 'danger')
+        return redirect(url_for('tryouts.view_tryout', tryout_id=tryout_id))
+
     if not current_user.can_manage_this_tryout(tryout):
         flash(_('Permission denied.'), 'danger')
         return redirect(url_for('tryouts.list_tryouts'))
 
-    if tryouts_locked():
-        flash(_('Tryouts are currently closed. An admin must open tryouts before changes can be made.'), 'danger')
-        return redirect(url_for('tryouts.view_tryout', tryout_id=tryout_id))
-
     player = db.get_or_404(User, player_id)
 
     registration = TryoutRegistration.query.filter_by(
@@ -640,12 +642,12 @@ def remove_player(tryout_id, player_id):
 def create_team(tryout_id):
     """Create a tryout-specific team."""
     tryout = db.get_or_404(Tryout, tryout_id)
-    if not current_user.can_manage_this_tryout(tryout):
-        flash(_('Permission denied.'), 'danger')
+    if tryouts_locked():
+        flash('Tryouts are currently closed. An admin must open tryouts before changes can be made.', 'danger')
         return redirect(url_for('tryouts.view_tryout', tryout_id=tryout_id))
 
-    if tryouts_locked():
-        flash(_('Tryouts are currently closed. An admin must open tryouts before changes can be made.'), 'danger')
+    if not current_user.can_manage_this_tryout(tryout):
+        flash(_('Permission denied.'), 'danger')
         return redirect(url_for('tryouts.view_tryout', tryout_id=tryout_id))
 
     try:
@@ -667,12 +669,12 @@ def add_to_team(tryout_id, team_id):
     """Add a player to a tryout team."""
     team = db.get_or_404(Team, team_id)
     tryout = db.get_or_404(Tryout, tryout_id)
-    if not current_user.can_manage_this_tryout(tryout):
-        flash(_('Permission denied.'), 'danger')
+    if tryouts_locked():
+        flash('Tryouts are currently closed. An admin must open tryouts before changes can be made.', 'danger')
         return redirect(url_for('tryouts.view_tryout', tryout_id=tryout_id))
 
-    if tryouts_locked():
-        flash(_('Tryouts are currently closed. An admin must open tryouts before changes can be made.'), 'danger')
+    if not current_user.can_manage_this_tryout(tryout):
+        flash(_('Permission denied.'), 'danger')
         return redirect(url_for('tryouts.view_tryout', tryout_id=tryout_id))
 
     # The two ids arrive independently in the URL. Without this check, being
@@ -713,14 +715,14 @@ def add_to_team(tryout_id, team_id):
 def delete_tryout(tryout_id):
     """Delete a tryout and all associated data (matches, teams, registrations, evaluations)."""
     tryout = db.get_or_404(Tryout, tryout_id)
+    if tryouts_locked():
+        flash('Tryouts are currently closed. An admin must open tryouts before changes can be made.', 'danger')
+        return redirect(url_for('tryouts.view_tryout', tryout_id=tryout_id))
+
     if not current_user.can_manage_this_tryout(tryout):
         flash(_('You do not have permission to delete this tryout.'), 'danger')
         return redirect(url_for('tryouts.list_tryouts'))
 
-    if tryouts_locked():
-        flash(_('Tryouts are currently closed. An admin must open tryouts before changes can be made.'), 'danger')
-        return redirect(url_for('tryouts.view_tryout', tryout_id=tryout_id))
-
     match_ids = [m.id for m in Match.query.filter_by(tryout_id=tryout_id).all()]
     team_ids = [t.id for t in Team.query.filter_by(tryout_id=tryout_id).all()]