Fix probleme d'evaluation

app/routes/evaluations.py

@@ -37,6 +37,32 @@ def _users_by_id(user_ids):
     return {user.id: user for user in User.query.filter(User.id.in_(wanted)).all()}
 
 
+def validate_score(score_value):
+    """Turn a raw form value into a criterion score (1..10), or None.
+
+    A blank value means "not assessed". Anything else outside 1..10 is a
+    validation error, matching the single-player form's ``EvaluationSchema``
+    -- a coach must not be able to quietly turn 11 or 0 into "no score"
+    (QUA-003).
+    """
+    if score_value is None or str(score_value).strip() == '':
+        return None
+    try:
+        score = int(score_value)
+    except (TypeError, ValueError) as exc:
+        raise ValidationError('A score must be a whole number from 1 to 10.') from exc
+    if not 1 <= score <= 10:
+        raise ValidationError('Scores run from 1 to 10.')
+    return score
+
+
+def _apply_evaluation(evaluation, scores, comments, position):
+    """Write validated scores, comments and position onto an Evaluation."""
+    evaluation.apply_scores(scores)
+    evaluation.comments = comments
+    evaluation.position_recommendation = position
+
+
 @evaluations_bp.route('')
 @login_required
 def list_evaluations():
@@ -317,27 +343,38 @@ def batch_evaluate(tryout_id):
 
     if request.method == 'POST':
         saved = 0
-        for entry in players:
-            pid = entry['player'].id
-            scores = {
-                field_name: validate_score(request.form.get(f'{field_name}_{pid}'))
-                for field_name, _ in EVALUATION_CRITERIA
-            }
-            comments = request.form.get(f'comments_{pid}')
-            position = request.form.get(f'position_recommendation_{pid}')
+        try:
+            for entry in players:
+                pid = entry['player'].id
+                scores = {
+                    field_name: validate_score(request.form.get(f'{field_name}_{pid}'))
+                    for field_name, _ in EVALUATION_CRITERIA
+                }
+                comments = request.form.get(f'comments_{pid}')
+                position = request.form.get(f'position_recommendation_{pid}')
 
-            existing = entry['existing']
-            if existing:
-                _apply_evaluation(existing, scores, comments, position)
-            else:
-                evaluation = Evaluation(
-                    tryout_id=tryout_id,
-                    player_id=pid,
-                    evaluator_id=current_user.id,
-                )
-                _apply_evaluation(evaluation, scores, comments, position)
-                db.session.add(evaluation)
-            saved += 1
+                existing = entry['existing']
+                if existing:
+                    _apply_evaluation(existing, scores, comments, position)
+                else:
+                    evaluation = Evaluation(
+                        tryout_id=tryout_id,
+                        player_id=pid,
+                        evaluator_id=current_user.id,
+                    )
+                    _apply_evaluation(evaluation, scores, comments, position)
+                    db.session.add(evaluation)
+                saved += 1
+        except ValidationError:
+            db.session.rollback()
+            flash(_('Scores must be whole numbers from 1 to 10.'), 'danger')
+            return render_template(
+                'pages/batch_evaluate.html',
+                tryout=tryout,
+                players=players,
+                evaluation_criteria=EVALUATION_CRITERIA,
+                game_positions=GAME_POSITIONS,
+            )
 
         db.session.commit()
         flash(f'Saved evaluations for {saved} player(s).', 'success')