"""Input validation schemas for the Team Tryouts application. This module provides Marshmallow schemas for validating and sanitizing all user inputs including forms, JSON requests, and file uploads. All validation is centralized here for consistency and maintainability. Usage: from validators import LoginSchema schema = LoginSchema() errors = schema.validate(request.form) """ import re from flask_babel import lazy_gettext as _l from marshmallow import ( EXCLUDE, Schema, ValidationError, fields, pre_load, validate, validates_schema, ) from app.models import ESPORT_GAMES, USER_TYPES # ============================================================================= # Custom Validators # ============================================================================= PASSWORD_POLICY = re.compile(r'^(?=.*[a-z])(?=.*[A-Z])(?=.*\d).{8,}$') """Password policy: minimum 8 chars, 1 uppercase, 1 lowercase, 1 digit.""" def validate_password(value): """Validate password meets strength requirements. Requires: minimum 8 characters, at least one uppercase letter, one lowercase letter, and one digit. Args: value: The password string to validate. Raises: ValidationError: If password does not meet requirements. """ if not PASSWORD_POLICY.match(value): raise ValidationError( _l('Password must be at least 8 characters with uppercase, lowercase, and a number.') ) def validate_username(value): """Validate username format. Usernames must be 3-30 characters and contain only alphanumeric characters, underscores, and hyphens. Args: value: The username string to validate. Raises: ValidationError: If username does not meet requirements. """ if not re.match(r'^[a-zA-Z0-9_-]{3,30}$', value): raise ValidationError( _l('Username must be 3-30 characters (letters, numbers, underscore, hyphen).') ) def validate_discord_username(value): """Validate Discord username format if provided. Accepts empty strings (optional field). Validates that the username matches common Discord username patterns. Args: value: The Discord username to validate. Raises: ValidationError: If the format is invalid. """ if not value: return if not re.match(r'^[a-zA-Z0-9_.]{2,32}$', value): raise ValidationError(_l('Invalid Discord username format.')) def validate_discord_user_id(value): """Validate Discord user ID (snowflake) if provided. Discord user IDs are 17-20 digit numbers. Args: value: The Discord user ID to validate. Raises: ValidationError: If the format is invalid. """ if not value: return if not re.match(r'^\d{17,20}$', value): raise ValidationError(_l('Discord User ID must be a 17-20 digit number.')) def validate_phone(value): """Validate optional phone number format. Accepts empty strings. Validates common phone formats. Args: value: The phone number to validate. Raises: ValidationError: If the format is invalid. """ if not value: return cleaned = re.sub(r'[\s\-\(\)\.]', '', value) if not re.match(r'^\+?\d{7,15}$', cleaned): raise ValidationError(_l('Invalid phone number format.')) # ============================================================================= # Validation Schemas # ============================================================================= class StripMixin(Schema): """Mixin that automatically strips whitespace from all string fields and ignores unknown fields (e.g., csrf_token from Flask-WTF).""" class Meta: """Marshmallow Meta options.""" unknown = EXCLUDE # Ignore csrf_token and other unknown fields @pre_load def normalise_form_values(self, data, **kwargs): """Strip whitespace, and read an empty input as an absent one. Both halves in one hook rather than two: marshmallow gives no ordering guarantee between several pre_load hooks on the same schema, and these two have to happen in this order. The second half is what let the match and tryout forms be validated at all (ARCH-005). An HTML form submits every field it renders, so an untouched optional date arrives as '' rather than not arriving — and '' is not a date, so a schema written the obvious way rejected every form with a blank optional field. Dropping the key instead lets `load_default` do its job. Only fields the schema declares as optional are dropped. A blank *required* field still has to fail, and say so. Args: data: The input dictionary. Returns: dict: Data with stripped strings and blank optionals removed. """ if not isinstance(data, dict): return data stripped = {k: v.strip() if isinstance(v, str) else v for k, v in data.items()} return { key: value for key, value in stripped.items() if value != '' or self._is_required(key) or self._accepts_blank(key) } def _is_required(self, key): field = self.fields.get(key) return field is not None and field.required def _accepts_blank(self, key): """True when '' is a value this field means to receive. A plain String is one: `description=''` on an edit form means "clear the description", not "leave it alone". An Email is not — there is no such thing as an empty address, so a blank one is an absent one. Typed fields (Integer, Date, Time, List) are not Strings and so are never kept blank, which is the whole point of the hook. """ field = self.fields.get(key) return isinstance(field, fields.String) and not isinstance(field, fields.Email) class LoginSchema(StripMixin): """Validate login form input. Fields: username: 3-30 chars, required. password: Non-empty, required. """ username = fields.String( required=True, validate=validate.Length(min=1, max=80, error=_l('Username is required.')), ) password = fields.String( required=True, validate=validate.Length(min=1, error=_l('Password is required.')), ) class RegisterSchema(StripMixin): """Validate player registration form input. Fields: username: 3-30 chars alphanumeric, required. email: Valid email, required. password: Meets password policy, required. confirm_password: Must match password, required. full_name: 1-100 chars, required. phone: Optional, valid phone format. games: Optional list. discord_username: Optional, valid format. league_os_profile: Optional URL. """ username = fields.String( required=True, validate=[ validate.Length(min=3, max=80, error=_l('Username must be 3-80 characters.')), validate_username, ], ) email = fields.Email( required=True, validate=validate.Length(max=120, error=_l('Email must be 120 characters or less.')), ) password = fields.String( required=True, validate=validate_password, load_only=True, ) confirm_password = fields.String( required=True, load_only=True, ) full_name = fields.String( required=True, validate=validate.Length(min=1, max=100, error=_l('Full name is required.')), ) phone = fields.String( validate=validate_phone, allow_none=True, load_default=None, ) games = fields.List(fields.String(), load_default=[]) discord_username = fields.String( validate=validate_discord_username, allow_none=True, load_default=None, ) discord_user_id = fields.String( validate=validate_discord_user_id, allow_none=True, load_default=None, ) league_os_profile = fields.String( validate=validate.Length(max=256), allow_none=True, load_default=None, ) @validates_schema def validate_password_match(self, data, **kwargs): """Ensure confirm_password matches password. Args: data: The validated data dictionary. Raises: ValidationError: If passwords do not match. """ if data.get('password') != data.get('confirm_password'): raise ValidationError(_l('Passwords do not match.'), field_name='confirm_password') class CreateUserSchema(StripMixin): """Validate president-created user form input. Fields: username: 3-30 chars alphanumeric, required. email: Valid email, required. password: Meets password policy, required. full_name: 1-100 chars, required. role: Must be valid role, required. phone: Optional, valid phone format. """ username = fields.String( required=True, validate=[ validate.Length(min=3, max=80, error=_l('Username must be 3-80 characters.')), validate_username, ], ) email = fields.Email( required=True, validate=validate.Length(max=120), ) password = fields.String( required=True, validate=validate_password, load_only=True, ) full_name = fields.String( required=True, validate=validate.Length(min=1, max=100, error=_l('Full name is required.')), ) role = fields.String( required=True, validate=validate.OneOf(USER_TYPES, error=_l('Invalid role selected.')), ) phone = fields.String( validate=validate_phone, allow_none=True, load_default=None, ) class EditUserSchema(StripMixin): """Validate president-edited user form input. Fields: full_name: 1-100 chars, required. email: Valid email, required. role: Must be valid role, required. is_active_account: Boolean. phone: Optional. password: Optional (only if changing). discord_username: Optional. discord_user_id: Optional. league_os_profile: Optional. games: Optional list. """ full_name = fields.String( required=True, validate=validate.Length(min=1, max=100, error=_l('Full name is required.')), ) email = fields.Email( required=True, validate=validate.Length(max=120), ) role = fields.String( required=True, validate=validate.OneOf(USER_TYPES, error=_l('Invalid role selected.')), ) is_active_account = fields.Boolean(load_default=True) phone = fields.String( validate=validate_phone, allow_none=True, load_default=None, ) password = fields.String( validate=validate_password, load_only=True, allow_none=True, load_default='', ) discord_username = fields.String( validate=validate_discord_username, allow_none=True, load_default=None, ) discord_user_id = fields.String( validate=validate_discord_user_id, allow_none=True, load_default=None, ) league_os_profile = fields.String( validate=validate.Length(max=256), allow_none=True, load_default=None, ) games = fields.List(fields.String(), load_default=[]) class EditProfileSchema(StripMixin): """Validate self-edit profile form input. Fields: username: 3-30 chars, required. full_name: 1-100 chars, required. email: Valid email, required. phone: Optional. password: Optional (only if changing). discord_username: Optional. discord_user_id: Optional. league_os_profile: Optional. games: Optional list. """ username = fields.String( required=True, validate=[ validate.Length(min=3, max=80), validate_username, ], ) full_name = fields.String( required=True, validate=validate.Length(min=1, max=100, error=_l('Full name is required.')), ) email = fields.Email( required=True, validate=validate.Length(max=120), ) phone = fields.String( validate=validate_phone, allow_none=True, load_default=None, ) password = fields.String( validate=validate_password, load_only=True, allow_none=True, load_default='', ) discord_username = fields.String( validate=validate_discord_username, allow_none=True, load_default=None, ) discord_user_id = fields.String( validate=validate_discord_user_id, allow_none=True, load_default=None, ) league_os_profile = fields.String( validate=validate.Length(max=256), allow_none=True, load_default=None, ) games = fields.List(fields.String(), load_default=[]) class UploadContractSchema(StripMixin): """Validate contract upload form input. Fields: player_id: Integer, required. notes: Optional text. """ player_id = fields.Integer( required=True, validate=validate.Range(min=1, error=_l('Player must be selected.')), ) notes = fields.String( validate=validate.Length(max=2000, error=_l('Notes must be 2000 characters or less.')), allow_none=True, load_default=None, ) #: Where a player stands on a team roster. #: #: `TeamPlayer.status` is a NOT NULL String(20) that `add_player` filled from #: `request.form.get('status', 'starter')` with no check at all, so a forged #: submission stored any string it liked. It then survived until someone #: pressed the toggle, which reads `'substitute' if status == 'starter' else #: 'starter'` — so an unknown value silently became `starter`, i.e. promoted #: whoever held it (SEC-16). TEAM_PLAYER_STATUSES = ('starter', 'substitute') class TeamStaffSchema(StripMixin): """One staff id, posted by the add/remove coach and manager forms. Both ids are optional here even though each route needs exactly one: `remove_coach` treats an absent id as "remove every coach", and the add routes already carry their own translated "Please select a coach." message. Making the field required would replace that message with a generic one for no gain. What this schema is for is the conversion. Wave K closed `create_team` and `edit_team` and left five sibling routes reading `int(...)` straight off the form — a non-numeric id was a 500 in each. Fixing a pattern in one place and not its neighbours is the mistake this project keeps making; this is the same mistake, made by the fix for it. """ coach_id = fields.Integer( allow_none=True, load_default=None, validate=validate.Range(min=1), error_messages={'invalid': _l('Invalid coach selection.')}, ) manager_id = fields.Integer( allow_none=True, load_default=None, validate=validate.Range(min=1), error_messages={'invalid': _l('Invalid manager selection.')}, ) class TeamPlayerSchema(StripMixin): """A player being put on a team roster, and where they stand on it.""" player_id = fields.Integer( allow_none=True, load_default=None, validate=validate.Range(min=1), error_messages={'invalid': _l('Invalid player selection.')}, ) status = fields.String( load_default='starter', validate=validate.OneOf(TEAM_PLAYER_STATUSES, error=_l('Unknown roster status.')), ) class OneOnOneRequestSchema(StripMixin): """A player asking their coach for a session (MNT-12). This schema existed before and **was never called**: not imported by any route, not exercised by any test. `one_on_one.py` parsed the same three fields by hand, three lines apart, and parsed the date a second time to get its weekday. That is the pattern the audit named as SEC-AUTHZ-001 — a validation policy that is written down and not applied — surviving in a corner nobody had looked at since. The fields were `String` + `Regexp`, which checked the shape and left the caller to convert. `Date` and `Time` do both, so the route receives the objects it is going to store and the "is this a date" question is asked once, in one place. """ date = fields.Date( required=True, error_messages={ 'invalid': _l('Date must be in YYYY-MM-DD format.'), 'required': _l('A date is required.'), }, ) start_time = fields.Time( required=True, error_messages={ 'invalid': _l('Start time must be in HH:MM format.'), 'required': _l('A start time is required.'), }, ) end_time = fields.Time( required=True, error_messages={ 'invalid': _l('End time must be in HH:MM format.'), 'required': _l('An end time is required.'), }, ) points = fields.String( validate=validate.Length(max=2000, error=_l('Points must be 2000 characters or less.')), allow_none=True, load_default=None, ) @validates_schema def validate_window(self, data, **kwargs): """A session cannot end before it starts. Nothing checked this. The form's own `