GGThedandClaude Opus 5
7cec18c139
QUA-002, premiere moitie. **Ce commit ne fait que reformater** : aucun changement de comportement, aucune ligne de logique touchee. 72 fichiers, 4 restaient deja conformes. Il est isole exprès, pour que `git log -p` sur les commits voisins reste lisible. `quote-style = "preserve"` etait deja pose dans pyproject.toml, ce qui evite le brassage guillemets simples / doubles : le diff porte sur les retours a la ligne, l indentation des appels longs et les virgules finales, pas sur le style de chaine. Verification : 263 tests passent avant et apres, ruff check propre. L activation en CI arrive dans le commit suivant, separement, pour que ce diff-ci ne contienne rien d autre. Co-Authored-By: Claude Opus 5 <[email protected]>
68 lines
2.7 KiB
Python
68 lines
2.7 KiB
Python
"""Contract documents for players to sign."""
|
|
|
|
from app.extensions import db
|
|
from datetime import datetime
|
|
|
|
|
|
class Contract(db.Model):
|
|
"""Contract documents for players to sign."""
|
|
|
|
__tablename__ = 'contracts'
|
|
id = db.Column(db.Integer, primary_key=True)
|
|
player_id = db.Column(db.Integer, db.ForeignKey('users.id'), nullable=False)
|
|
team_id = db.Column(db.Integer, db.ForeignKey('org_teams.id'), nullable=True)
|
|
uploaded_by_id = db.Column(db.Integer, db.ForeignKey('users.id'), nullable=False)
|
|
|
|
original_filename = db.Column(db.String(255), nullable=False)
|
|
stored_filename = db.Column(db.String(255), nullable=False)
|
|
file_path = db.Column(db.String(500), nullable=False)
|
|
|
|
signed_filename = db.Column(db.String(255), nullable=True)
|
|
signed_file_path = db.Column(db.String(500), nullable=True)
|
|
|
|
status = db.Column(db.String(20), default='pending')
|
|
notes = db.Column(db.Text, nullable=True)
|
|
uploaded_at = db.Column(db.DateTime, default=datetime.utcnow)
|
|
signed_at = db.Column(db.DateTime, nullable=True)
|
|
|
|
player = db.relationship('User', foreign_keys=[player_id], backref='contracts')
|
|
team = db.relationship('OrgTeam', foreign_keys=[team_id])
|
|
uploader = db.relationship('User', foreign_keys=[uploaded_by_id])
|
|
|
|
def can_view(self, user):
|
|
"""Whether this user may read the contract and download its files.
|
|
|
|
Two defects used to sit in the coach branch:
|
|
|
|
- `not self.team_id` acted as a wildcard, so any coach listed in the
|
|
legacy OrgTeam.coach_id column could read every contract with no
|
|
team attached — and upload_contract leaves team_id null whenever
|
|
the player belongs to no team.
|
|
- the lookup went through OrgTeam.coach_id only, so a coach attached
|
|
through the many-to-many relationship saw nothing at all.
|
|
|
|
Access now follows the same rule as everywhere else: the coach and
|
|
the player must actually work together.
|
|
"""
|
|
if user.id == self.player_id:
|
|
return True
|
|
|
|
from app.models.user_model.admin import Admin
|
|
from app.models.user_model.manager import Manager
|
|
from app.models.user_model.coach import Coach
|
|
from app.models.user_model.user import User
|
|
from app.permissions import coach_can_access_player
|
|
|
|
if isinstance(user, Admin):
|
|
return True
|
|
if isinstance(user, Manager):
|
|
player = User.query.get(self.player_id)
|
|
if player and player.get_org_teams():
|
|
return True
|
|
if isinstance(user, Coach):
|
|
return coach_can_access_player(user, self.player_id)
|
|
return False
|
|
|
|
def can_upload_signed(self, user):
|
|
return user.id == self.player_id
|